[Refactor][httpv2]remove http v1 code #8848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http v2 has been actually tested in production, and it is completely replaceable to have http code. In order to simplify code maintenance, remove the previous http part of the code
morningman
added
kind/api-change
morningman
reviewed
Apr 6, 2022
| super(""); | ||
| } | ||
| public IllegalArgException() { | ||
| super(""); |
| this.msg = msg; | ||
| } | ||
| public RestBaseResult(String msg) { | ||
| status = ActionStatus.FAILED; |
| resultMap.put(key, value); | ||
| } | ||
| public RestResult() { | ||
| super(); |
code style
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
morningman
pushed a commit
that referenced
this pull request
Apr 8, 2022
http v2 has been actually tested in production, and it is completely replaceable to have http code. In order to simplify code maintenance, remove the previous http part of the code
morningman
added
dev/merged-1.0.1-deprecated
morningman
added a commit
that referenced
this pull request
Apr 14, 2022
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 22, 2022
http v2 has been actually tested in production, and it is completely replaceable to have http code. In order to simplify code maintenance, remove the previous http part of the code
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 22, 2022
1. The compile bug is introduced from apache#8855 2. FE ut bug is introduced from apache#8848 and apache#8770
zhengshiJ
pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
Apr 27, 2022
1. The compile bug is introduced from apache#8855 2. FE ut bug is introduced from apache#8848 and apache#8770
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
1. The compile bug is introduced from apache#8855 2. FE ut bug is introduced from apache#8848 and apache#8770
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
1. The compile bug is introduced from apache#8855 2. FE ut bug is introduced from apache#8848 and apache#8770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http v2 has been actually tested in production, and it is completely replaceable to have http code. In order to simplify code maintenance, remove the previous http part of the code
Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...