-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Bug] [Storage-Vectorized] query get wrong result when read datetime type column #8872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test case.
|
It doesn't seem to solve the problem completely, there is still a wrong case ~ |
It seems that the code in |
update fix
I will submit a separate pr after this pr merged. |
| _year(0) {} // before int128 16 bytes ---> after int64 8 bytes | ||
|
|
||
| explicit VecDateTimeValue(int64_t t) { from_date_int64(t); } | ||
| static VecDateTimeValue create_from_olap_date(uint64_t value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment what's the different between create_from_olap_datetime and create_from_normal_datetime. it is default to know the different from the name of function name.
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
Proposed changes
Issue Number: close #8871
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...