[Enhancement][Regression-Test] enhancement for regression-test framework #8930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiteTheDDDDt
force-pushed
the
dev_0408
branch
2 times, most recently
from
e0316d6 to
aa785ea
Compare
3 tasks
924060929
reviewed
Apr 11, 2022
| } | ||
|
|
||
| static String checkCell(String info, int line, String expect_cell, String real_cell, String data_type) { | ||
| if(data_type == "FLOAT" || data_type == "DOUBLE") { |
Contributor
There was a problem hiding this comment.
suggest change to camel case
| class JdbcUtils { | ||
| static List<List<Object>> executeToList(Connection conn, String sql) { | ||
| static List<List<Object>> executeToList(Connection conn, String sql, Metaholder holder) { | ||
| conn.prepareStatement(sql).withCloseable { stmt -> |
Contributor
There was a problem hiding this comment.
suggest new Metaholder in JdbcUtils and return, and you can extract the interest metadata out of the Connection life cycle safely.
e.g.
class Metadata {
public final List<String> columnNames;
public final List<String> columnTypes;
}
static Tuple2<List<List<Object>>, Metadata> executeToList(Connection conn, String sql) {
def metadata = new Metadata()
resultList = ...
metadata.columnNames = ...
metadata.columnTypes = ...
return [resultList, metadata]
}then, you can take result by this code
def (result, metadata) = JdbcUtils.executeToList(connnection, sql)
update update
fix reset
BiteTheDDDDt
force-pushed
the
dev_0408
branch
2 times, most recently
from
4228a3c to
7cd7982
Compare
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
Contributor
|
PR approved by anyone and no changes requested. |
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 22, 2022
zhengshiJ
pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
Apr 27, 2022
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
@924060929 PTAL
Issue Number: close #8729
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...