Skip to content

Conversation

@cambyzju
Copy link
Contributor

Proposed changes

Issue Number: close #7570

Problem Summary:

  1. change SSB tables (add ARRAY column), and test SSB sql, find some bugs while read Array Column;
  2. fix UT failed in write_var_uint;

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added the area/array-type Issues or PRs related to array type label Apr 21, 2022
@cambyzju cambyzju force-pushed the array-read-bugfix branch from 0add808 to e778367 Compare April 24, 2022 02:28
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 88115ff into apache:master Apr 26, 2022
@morningman morningman added the dev/backlog waiting to be merged in future dev branch label Apr 26, 2022
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 26, 2022
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/array-type Issues or PRs related to array type area/vectorization dev/backlog waiting to be merged in future dev branch reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Roadmap] Support Array Type(Q1)

3 participants