Skip to content

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Apr 20, 2022

Proposed changes

Issue Number: close #9116

Problem Summary:

Please refer to #9116

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: No Need
  3. Has document been added or modified: No Need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Apr 20, 2022
@jackwener
Copy link
Member

License Check / License Check (pull_request) Failing.

Maybe solution.

  • New file need header.
  • Rebase

@adonis0147
Copy link
Contributor Author

License was added.

@morningman morningman added the dev/backlog waiting to be merged in future dev branch label Apr 27, 2022
@adonis0147 adonis0147 force-pushed the diagnostics branch 3 times, most recently from 2342436 to e51d133 Compare April 27, 2022 17:00
@adonis0147
Copy link
Contributor Author

adonis0147 commented May 30, 2022

Hi @morningman, PTAL

@adonis0147 adonis0147 closed this May 30, 2022
@adonis0147 adonis0147 reopened this May 30, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit fc9afda into apache:master Jun 8, 2022
@adonis0147 adonis0147 deleted the diagnostics branch June 8, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/backlog waiting to be merged in future dev branch reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] [diagnostics] Use clangd to detect unused includes.

4 participants