-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](k8s) Support fqdn mode for be in k8s enviroment #9172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe/fe-core/src/main/java/org/apache/doris/alter/SystemHandler.java
Outdated
Show resolved
Hide resolved
|
|
Config.enable_k8s_container_drift_mode config is master only, replay operation no need depend on this config. |
fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
Outdated
Show resolved
Hide resolved
|
LGTM |
fe/fe-core/src/main/java/org/apache/doris/analysis/BackendClause.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java
Outdated
Show resolved
Hide resolved
|
This PR needs some more detailed description:
|
94dc530 to
430342d
Compare
|
TeamCity pipeline, clickbench performance test result: |
74e0b66 to
e03a45e
Compare
|
fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/system/FQDNManager.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/system/FQDNManager.java
Outdated
Show resolved
Hide resolved
b28fac1 to
2a6a454
Compare
2a6a454 to
1b62ea0
Compare
fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
Outdated
Show resolved
Hide resolved
| private long id; | ||
| @SerializedName("host") | ||
| private String host; | ||
| private volatile String host; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我们最好在这里做一下区分,ipaddress 和 host name, 感觉现在这个host 和 hostname 区分不清楚。
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Proposed changes
Issue Number: close #9171
Problem Summary:
In the k8s environment, the ip of the pod can be changed, but the hostname of pod is stable. When the host machine of the pod fails, the k8s can schedule the failed pod to the new host machine for reconstruction. After that, the newly created pod's hostname remains unchanged, and the ip address has been changed. The change of the be node's ip address can be detected by FQDNManager when enable_fqdn_mode is true
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...