[Improvement] not print logs to fe.out when fe is running under daemon #9195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangshuo128
reviewed
Apr 24, 2022
| // ErrorName, ErrorCode, String Description, Should print stacktrace | ||
| #define APPLY_FOR_ERROR_CODES(M) \ | ||
| M(OLAP_SUCCESS, 0, "", true) \ | ||
| M(OLAP_SUCCESS, 0, "", false) \ |
Contributor
There was a problem hiding this comment.
Because we don't need to print stack trace for OLAP_SUCCESS
morningman
approved these changes
Apr 24, 2022
| // ErrorName, ErrorCode, String Description, Should print stacktrace | ||
| #define APPLY_FOR_ERROR_CODES(M) \ | ||
| M(OLAP_SUCCESS, 0, "", true) \ | ||
| M(OLAP_SUCCESS, 0, "", false) \ |
Contributor
There was a problem hiding this comment.
Because we don't need to print stack trace for OLAP_SUCCESS
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added
kind/fix
Contributor
|
PR approved by anyone and no changes requested. |
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 25, 2022
…n mode (apache#9195) Co-authored-by: yiguolei <yiguolei@gmail.com> (cherry picked from commit 3bdfcde)
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 26, 2022
…n mode (apache#9195) Co-authored-by: yiguolei <yiguolei@gmail.com> (cherry picked from commit 3bdfcde)
morningman
added
dev/1.0.1-deprecated
morningman
pushed a commit
that referenced
this pull request
Apr 28, 2022
…n mode (#9195) Co-authored-by: yiguolei <yiguolei@gmail.com>
morningman
added
dev/merged-1.0.1-deprecated
Kikyou1997
pushed a commit
to Kikyou1997/incubator-doris
that referenced
this pull request
May 9, 2022
…n mode (apache#9195) Co-authored-by: yiguolei <yiguolei@gmail.com>
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
…n mode (apache#9195) Co-authored-by: yiguolei <yiguolei@gmail.com>
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
…n mode (apache#9195) Co-authored-by: yiguolei <yiguolei@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...