Skip to content

Conversation

@chenlinzhong
Copy link
Contributor

Proposed changes

Issue Number:

Problem Summary:

  • now all pr failed in "BE Code Formatter / Clang Formatter" check
  • sh build-support/clang-format.sh to clang-format all c++ code

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Apr 28, 2022
@morningman
Copy link
Contributor

@chenlinzhong please rebase because #9280 has been merged

@morningman
Copy link
Contributor

And you'd better send an email to dev@doris to notice others.
Because this PR may be conflict with all other PRs.

@chenlinzhong
Copy link
Contributor Author

@chenlinzhong please rebase because #9280 has been merged

done

@morningman
Copy link
Contributor

@chenlinzhong
Copy link
Contributor Author

chenlinzhong commented Apr 29, 2022

done @morningman

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 29, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit c9961c9 into apache:master Apr 29, 2022
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
- sh build-support/clang-format.sh  to  clang-format all c++ code
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
- sh build-support/clang-format.sh  to  clang-format all c++ code
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
- sh build-support/clang-format.sh  to  clang-format all c++ code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants