Skip to content

[fix](ut) Fix MarkDownParserTest #9332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Apr 30, 2022
Merged

[fix](ut) Fix MarkDownParserTest #9332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 40 additions & 52 deletions fe/fe-core/src/test/java/org/apache/doris/common/MarkDownParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.doris.common;

import com.google.common.collect.Lists;

import org.junit.Assert;
import org.junit.Test;

Expand All @@ -29,25 +30,25 @@ public class MarkDownParserTest {
@Test
public void testNormal() throws UserException {
List<String> lines = Lists.newArrayList();
lines.add("# SHOW TABLES");
lines.add("## name");
lines.add("## SHOW TABLES");
lines.add("### name");
lines.add("SHOW TABLES");
lines.add("## description");
lines.add("### description");
lines.add("SYNTAX:");
lines.add("\tSHOW TABLES [FROM] database");
lines.add("## example");
lines.add("### example");
lines.add("show tables;");
lines.add("## keyword");
lines.add("### keywords");
lines.add("SHOW, TABLES");
lines.add("## url");
lines.add("### url");
lines.add("http://www.baidu.com");
MarkDownParser parser = new MarkDownParser(lines);
Map<String, Map<String, String>> map = parser.parse();
Assert.assertNotNull(map.get("show taBLES"));
Assert.assertEquals("SHOW TABLES\n", map.get("SHOW TABLES").get("name"));
Assert.assertEquals("SYNTAX:\n\tSHOW TABLES [FROM] database\n", map.get("SHOW TABLES").get("description"));
Assert.assertEquals("show tables;\n", map.get("SHOW TABLES").get("example"));
Assert.assertEquals("SHOW, TABLES\n", map.get("SHOW TABLES").get("keyword"));
Assert.assertEquals("SHOW, TABLES\n", map.get("SHOW TABLES").get("keywords"));
Assert.assertEquals("http://www.baidu.com\n", map.get("SHOW TABLES").get("url"));
for (Map.Entry<String, Map<String, String>> doc : map.entrySet()) {
Assert.assertEquals("SHOW TABLES\n", doc.getValue().get("NAme"));
Expand All @@ -58,26 +59,30 @@ public void testNormal() throws UserException {
public void testMultiDoc() throws UserException {
List<String> lines = Lists.newArrayList();
lines.add(" name");
lines.add("# SHOW TABLES");
lines.add("## name");
lines.add("## SHOW TABLES");
lines.add("### name");
lines.add("SHOW TABLES");
lines.add("## description");
lines.add("### description");
lines.add("SYNTAX:\n\tSHOW TABLES [FROM] database");
lines.add("## example");
lines.add("### example");
lines.add("show tables;");
lines.add("## keyword");
lines.add("### keywords");
lines.add("SHOW, TABLES");
lines.add("## url");
lines.add("### url");
lines.add("http://www.baidu.com");
lines.add("# SHOW DATABASES");
lines.add("# DATABASES");
lines.add("## SHOW DATABASES");
lines.add("### description");
lines.add("### keywords");
lines.add("## DATABASES");
lines.add("### description");
lines.add("### keywords");
MarkDownParser parser = new MarkDownParser(lines);
Map<String, Map<String, String>> map = parser.parse();
Assert.assertNotNull(map.get("SHOW TABLES"));
Assert.assertEquals("SHOW TABLES\n", map.get("SHOW TABLES").get("name"));
Assert.assertEquals("SYNTAX:\n\tSHOW TABLES [FROM] database\n", map.get("SHOW TABLES").get("description"));
Assert.assertEquals("show tables;\n", map.get("SHOW TABLES").get("example"));
Assert.assertEquals("SHOW, TABLES\n", map.get("SHOW TABLES").get("keyword"));
Assert.assertEquals("SHOW, TABLES\n", map.get("SHOW TABLES").get("keywords"));
Assert.assertEquals("http://www.baidu.com\n", map.get("SHOW TABLES").get("url"));
Assert.assertNotNull(map.get("SHOW DATABASES"));
Assert.assertNotNull(map.get("DATABASES"));
Expand Down Expand Up @@ -117,79 +122,62 @@ public void testNoFirst() throws UserException {
Assert.fail("No exception throws.");
}

// When encounter a headlevel at 3 or greater, we ignore it rather than throw exception
// @Test(expected = UserException.class)
// public void testErrorState() throws UserException {
// List<String> lines = Lists.newArrayList();
// lines.add("# SHOW TABLES");
// lines.add("## name");
// lines.add("### name");
// MarkDownParser parser = new MarkDownParser(lines);
// Map<String, Map<String, String>> map = parser.parse();
// Assert.fail("No exception throws.");
// }

@Test
public void testMultiHeadLevel() throws UserException {
List<String> lines = Lists.newArrayList();
lines.add("# SHOW TABLES");
lines.add("## name");
lines.add("## SHOW TABLES");
lines.add("### name");
lines.add(" SHOW TABLES");
lines.add("## description");
lines.add("###Syntax");
lines.add("### description");
lines.add("####Syntax");
lines.add("SYNTAX:\n\tSHOW TABLES [FROM] database");
lines.add("####Parameter");
lines.add(">table_name");
lines.add("## example");
lines.add("### example");
lines.add("show tables;");
lines.add("### Exam1");
lines.add("#### Exam1");
lines.add("exam1");
lines.add("## keyword");
lines.add("### keywords");
lines.add("SHOW, TABLES");
lines.add("## url");
lines.add("### url");
lines.add("http://www.baidu.com");
MarkDownParser parser = new MarkDownParser(lines);
Map<String, Map<String, String>> map = parser.parse();
Assert.assertNotNull(map.get("SHOW TABLES"));
Assert.assertEquals(" SHOW TABLES\n", map.get("SHOW TABLES").get("name"));
Assert.assertEquals("Syntax\nSYNTAX:\n\tSHOW TABLES [FROM] database\nParameter\n>table_name\n", map.get("SHOW TABLES").get("description"));
Assert.assertEquals("show tables;\n Exam1\nexam1\n", map.get("SHOW TABLES").get("example"));
Assert.assertEquals("SHOW, TABLES\n", map.get("SHOW TABLES").get("keyword"));
Assert.assertEquals("####Syntax\nSYNTAX:\n\tSHOW TABLES [FROM] database\n####Parameter\n>table_name\n", map.get("SHOW TABLES").get("description"));
Assert.assertEquals("show tables;\n#### Exam1\nexam1\n", map.get("SHOW TABLES").get("example"));
Assert.assertEquals("SHOW, TABLES\n", map.get("SHOW TABLES").get("keywords"));
Assert.assertEquals("http://www.baidu.com\n", map.get("SHOW TABLES").get("url"));
}


@Test
// the level of "description" is wrong
@Test(expected = DdlException.class)
public void testEmptyTitle() throws UserException {
List<String> lines = Lists.newArrayList();
lines.add("#");
lines.add("## ");
lines.add("SHOW TABLES");
lines.add("## ");
lines.add("## description");
lines.add("SYNTAX:\n\tSHOW TABLES [FROM] database");
lines.add("## example");
lines.add("### example");
lines.add("show tables;");
lines.add("## keyword");
lines.add("### keywords");
lines.add("SHOW, TABLES");
lines.add("## url");
lines.add("### url");
lines.add("http://www.baidu.com");
MarkDownParser parser = new MarkDownParser(lines);
Map<String, Map<String, String>> map = parser.parse();
Assert.assertNotNull(map.get(""));
Assert.assertEquals("SYNTAX:\n\tSHOW TABLES [FROM] database\n", map.get("").get(""));
Assert.assertEquals("show tables;\n", map.get("").get("example"));
Assert.assertEquals("SHOW, TABLES\n", map.get("").get("keyword"));
Assert.assertEquals("http://www.baidu.com\n", map.get("").get("url"));
}

// no valid topic
@Test
public void testOneName() throws UserException {
List<String> lines = Lists.newArrayList();
lines.add("# TABLES");
lines.add("# TABLE");
MarkDownParser parser = new MarkDownParser(lines);
Map<String, Map<String, String>> map = parser.parse();
Assert.assertNotNull(map.get("TABLE"));
Assert.assertNotNull(map.get("TABLES"));
Assert.assertTrue(map.isEmpty());
}
}