Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Apr 30, 2022

Proposed changes

Issue Number: close #9340

Problem Summary:

  1. partition name is case insensitive.
  2. add a simple help-resource.zip to help pass the FE ut.

Checklist(Required)

  1. Does it affect the original behavior: (No)
  2. Has unit tests been added: (Yes)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 30, 2022
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for help-resource.zip?

@morningman
Copy link
Contributor Author

What is this used for help-resource.zip?

In #9306, I add a strict check to verify the format of "help" document, but it results in that the FE ut can not start locally
duo to miss the help-resource.zip.
So I add one for the FE unit test. There is only one empty doc inside it, just for passing the check.

Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

PR approved by anyone and no changes requested.

@morningman morningman merged commit f5f6293 into apache:master May 1, 2022
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request May 1, 2022
1. partition name is case insensitive.
2. add a simple help-resource.zip to help pass the FE ut.
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels May 6, 2022
morningman added a commit that referenced this pull request May 6, 2022
1. partition name is case insensitive.
2. add a simple help-resource.zip to help pass the FE ut.
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
1. partition name is case insensitive.
2. add a simple help-resource.zip to help pass the FE ut.
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
1. partition name is case insensitive.
2. add a simple help-resource.zip to help pass the FE ut.
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
1. partition name is case insensitive.
2. add a simple help-resource.zip to help pass the FE ut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] truncate partition with NPE

4 participants