Skip to content

Conversation

@Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #9343

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39
Copy link
Contributor Author

cc @HappenLee

morningman
morningman previously approved these changes May 1, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

Oh, I noticed that now the compaction operation is go through vmerge_rowsets directly without checking if vectorized is enabled. Is it safe? @Gabriel39 @HappenLee

@morningman morningman added the dev/backlog waiting to be merged in future dev branch label May 1, 2022
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 2, 2022
@Gabriel39
Copy link
Contributor Author

Oh, I noticed that now the compaction operation is go through vmerge_rowsets directly without checking if vectorized is enabled. Is it safe? @Gabriel39 @HappenLee

Config enable_vectorized_compaction has been added in last commit. Please review again @morningman

@Gabriel39 Gabriel39 force-pushed the bugfix_compaction branch from 7987288 to b0fd0d8 Compare May 2, 2022 11:58
@Gabriel39 Gabriel39 requested a review from morningman May 2, 2022 11:59
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 49a0cd1 into apache:master May 3, 2022
stalary pushed a commit to stalary/doris that referenced this pull request May 5, 2022
1. add a BE config to switch vectorized compaction
2. Fix vectorized compaction bug that row statistic is not right.
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
1. add a BE config to switch vectorized compaction
2. Fix vectorized compaction bug that row statistic is not right.
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
1. add a BE config to switch vectorized compaction
2. Fix vectorized compaction bug that row statistic is not right.
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
1. add a BE config to switch vectorized compaction
2. Fix vectorized compaction bug that row statistic is not right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization dev/backlog waiting to be merged in future dev branch reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Correctness check failed in vectorized compaction

2 participants