Skip to content

[Improvement] reduce string size in serialization #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
May 17, 2022
Merged

[Improvement] reduce string size in serialization #9550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/vec/columns/column_string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ ColumnPtr ColumnString::permute(const Permutation& perm, size_t limit) const {

StringRef ColumnString::serialize_value_into_arena(size_t n, Arena& arena,
char const*& begin) const {
size_t string_size = size_at(n);
UInt32 string_size = size_at(n);
size_t offset = offset_at(n);

StringRef res;
Expand All @@ -178,7 +178,7 @@ StringRef ColumnString::serialize_value_into_arena(size_t n, Arena& arena,
}

const char* ColumnString::deserialize_and_insert_from_arena(const char* pos) {
const size_t string_size = unaligned_load<size_t>(pos);
const UInt32 string_size = unaligned_load<UInt32>(pos);
pos += sizeof(string_size);

const size_t old_size = chars.size();
Expand Down