-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](nereids): add join rules base code #9598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,28 +15,43 @@ | |
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.rules.exploration; | ||
| package org.apache.doris.nereids.rules.exploration.join; | ||
|
|
||
| import org.apache.doris.nereids.rules.Rule; | ||
| import org.apache.doris.nereids.rules.RuleType; | ||
| import org.apache.doris.nereids.trees.plans.JoinType; | ||
| import org.apache.doris.nereids.rules.exploration.OneExplorationRuleFactory; | ||
| import org.apache.doris.nereids.trees.plans.Plan; | ||
| import org.apache.doris.nereids.trees.plans.logical.LogicalJoin; | ||
|
|
||
| /** | ||
| * rule factory for exchange inner join's children. | ||
| */ | ||
| public class JoinCommutative extends OneExplorationRuleFactory { | ||
| private boolean justApplyInnerOuterCrossJoin = false; | ||
|
|
||
| private final SwapType swapType; | ||
|
|
||
| /** | ||
| * If param is true, just apply rule in inner/full-outer/cross join. | ||
| */ | ||
| public JoinCommutative(boolean justApplyInnerOuterCrossJoin) { | ||
| this.justApplyInnerOuterCrossJoin = justApplyInnerOuterCrossJoin; | ||
| this.swapType = SwapType.ALL; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's this used for ?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. limit swap space, we should change
|
||
| } | ||
|
|
||
| public JoinCommutative(boolean justApplyInnerOuterCrossJoin, SwapType swapType) { | ||
| this.justApplyInnerOuterCrossJoin = justApplyInnerOuterCrossJoin; | ||
| this.swapType = swapType; | ||
| } | ||
|
|
||
| enum SwapType { | ||
| BOTTOM_JOIN, ZIG_ZAG, ALL | ||
| } | ||
|
|
||
| @Override | ||
| public Rule<Plan> build() { | ||
| return innerLogicalJoin().then(join -> { | ||
| // fixme, just for example now | ||
| return new LogicalJoin( | ||
| JoinType.INNER_JOIN, | ||
| join.getOnClause(), | ||
| join.right(), | ||
| join.left() | ||
| ); | ||
| return new LogicalJoin(join.getJoinType().swap(), join.getOnClause(), join.right(), join.left()); | ||
| }).toRule(RuleType.LOGICAL_JOIN_COMMUTATIVE); | ||
| } | ||
| } | ||
57 changes: 57 additions & 0 deletions
57
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinExchange.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.rules.exploration.join; | ||
|
|
||
| import org.apache.doris.nereids.rules.Rule; | ||
| import org.apache.doris.nereids.rules.RuleType; | ||
| import org.apache.doris.nereids.rules.exploration.OneExplorationRuleFactory; | ||
| import org.apache.doris.nereids.trees.plans.Plan; | ||
| import org.apache.doris.nereids.trees.plans.logical.LogicalJoin; | ||
|
|
||
|
|
||
| /** | ||
| * Rule for busy-tree, exchange the children node. | ||
| */ | ||
| public class JoinExchange extends OneExplorationRuleFactory { | ||
| /* | ||
| * topJoin newTopJoin | ||
| * / \ / \ | ||
| * leftJoin rightJoin --> newLeftJoin newRightJoin | ||
| * / \ / \ / \ / \ | ||
| * A B C D A C B D | ||
| */ | ||
| @Override | ||
| public Rule<Plan> build() { | ||
| return innerLogicalJoin(innerLogicalJoin(), innerLogicalJoin()).then(topJoin -> { | ||
| LogicalJoin leftJoin = topJoin.left(); | ||
| LogicalJoin rightJoin = topJoin.left(); | ||
|
|
||
| Plan a = leftJoin.left(); | ||
| Plan b = leftJoin.right(); | ||
| Plan c = rightJoin.left(); | ||
| Plan d = rightJoin.right(); | ||
|
|
||
| LogicalJoin newLeftJoin = new LogicalJoin(leftJoin.getJoinType(), leftJoin.getOnClause(), a, c); | ||
| LogicalJoin newRightJoin = new LogicalJoin(rightJoin.getJoinType(), rightJoin.getOnClause(), b, d); | ||
| LogicalJoin newTopJoin = | ||
| new LogicalJoin(topJoin.getJoinType(), topJoin.getOnClause(), newLeftJoin, newRightJoin); | ||
|
|
||
| return newTopJoin; | ||
| }).toRule(RuleType.LOGICAL_JOIN_EXCHANGE); | ||
| } | ||
| } |
54 changes: 54 additions & 0 deletions
54
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinLAsscom.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.rules.exploration.join; | ||
|
|
||
| import org.apache.doris.nereids.rules.Rule; | ||
| import org.apache.doris.nereids.rules.RuleType; | ||
| import org.apache.doris.nereids.rules.exploration.OneExplorationRuleFactory; | ||
| import org.apache.doris.nereids.trees.plans.Plan; | ||
| import org.apache.doris.nereids.trees.plans.logical.LogicalJoin; | ||
|
|
||
|
|
||
| /** | ||
| * Rule for change inner join left associative to right. | ||
| */ | ||
| public class JoinLAsscom extends OneExplorationRuleFactory { | ||
| /* | ||
| * topJoin newTopJoin | ||
| * / \ / \ | ||
| * bottomJoin C --> newBottomJoin B | ||
| * / \ / \ | ||
| * A B A C | ||
| */ | ||
| @Override | ||
| public Rule<Plan> build() { | ||
| return innerLogicalJoin(innerLogicalJoin(), any()).then(topJoin -> { | ||
| LogicalJoin bottomJoin = topJoin.left(); | ||
|
|
||
| Plan c = topJoin.right(); | ||
| Plan a = bottomJoin.left(); | ||
| Plan b = bottomJoin.right(); | ||
|
|
||
| LogicalJoin newBottomJoin = | ||
| new LogicalJoin(bottomJoin.getJoinType(), bottomJoin.getOnClause(), a, c); | ||
| LogicalJoin newTopJoin = | ||
| new LogicalJoin(bottomJoin.getJoinType(), topJoin.getOnClause(), newBottomJoin, b); | ||
| return newTopJoin; | ||
| }).toRule(RuleType.LOGICAL_JOIN_L_ASSCOM); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...e-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/JoinReorderContext.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.logical; | ||
|
|
||
|
|
||
| /** | ||
| * JoinReorderContext for Duplicate free. | ||
| * Paper: Improving Join Reorderability with Compensation Operators | ||
| */ | ||
| public class JoinReorderContext { | ||
| // left deep tree | ||
| private boolean hasCommute = false; | ||
| private boolean hasTopPushThrough = false; | ||
|
|
||
| public JoinReorderContext() { | ||
| } | ||
|
|
||
| void copyFrom(JoinReorderContext joinReorderContext) { | ||
| this.hasCommute = joinReorderContext.hasCommute; | ||
| this.hasTopPushThrough = joinReorderContext.hasTopPushThrough; | ||
| } | ||
|
|
||
| JoinReorderContext copy() { | ||
| JoinReorderContext joinReorderContext = new JoinReorderContext(); | ||
| joinReorderContext.copyFrom(this); | ||
| return joinReorderContext; | ||
| } | ||
|
|
||
| public boolean isHasCommute() { | ||
| return hasCommute; | ||
| } | ||
|
|
||
| public boolean isHasTopPushThrough() { | ||
| return hasTopPushThrough; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some unit test for those rule ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code is just an example.
Can't run.