Skip to content

[style] (fe) wrap and whitespace rules #9764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 4 commits into from
May 26, 2022
Merged

[style] (fe) wrap and whitespace rules #9764

morningman merged 4 commits into from
May 26, 2022

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented May 25, 2022

change below rules' severity to error and fix original code error:

  • EmptyBlock
  • EmptyCatchBlock
  • LeftCurly
  • RightCurly
  • IllegalTokenText
  • MultipleVariableDeclarations
  • OneStatementPerLine
  • StringLiteralEquality
  • UnusedLocalVariable
  • Indentation
  • OuterTypeFilename
  • MethodParamPad
  • GenericWhitespace
  • NoWhitespaceBefore
  • OperatorWrap
  • ParenPad
  • WhitespaceAfter
  • WhitespaceAround

Proposed changes

Issue Number: close #9405

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: No Need
  3. Has document been added or modified: No Need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

@morrySnow
[style] (fe) wrap and whitespace rules
76db2dd 
change below rules' severity to error and fix original code error:

- EmptyBlock
- EmptyCatchBlock
- LeftCurly
- RightCurly
- IllegalTokenText
- MultipleVariableDeclarations
- OneStatementPerLine
- StringLiteralEquality
- UnusedLocalVariable
- Indentation
- OuterTypeFilename
- MethodParamPad
- GenericWhitespace
- NoWhitespaceBefore
- OperatorWrap
- ParenPad
- WhitespaceAfter
- WhitespaceAround
@morrySnow morrySnow requested a review from morningman May 25, 2022 06:12
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels May 25, 2022
@morrySnow
Copy link
Contributor Author

morrySnow commented May 25, 2022

just like step 1 #9460 , all fe check style error is not related to the rules this patch care about

@morrySnow morrySnow added kind/refactor Issues or PRs to refactor code and removed area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/spark-load Issues or PRs related to the spark load area/routine load labels May 25, 2022
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels May 25, 2022
@morrySnow morrySnow removed area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/spark-load Issues or PRs related to the spark load area/routine load labels May 25, 2022
morningman
morningman reviewed May 26, 2022
View reviewed changes
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner labels May 26, 2022
@github-actions github-actions bot added area/routine load area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels May 26, 2022
@morrySnow morrySnow removed area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/spark-load Issues or PRs related to the spark load area/routine load labels May 26, 2022
morningman
morningman approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java Outdated
}

public boolean isUnNullSafeEquivalence() { return this == EQ; };
;
Copy link
Contributor

@morningman morningman May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

morningman commented May 26, 2022

I will merge this PR quickly to avoid further conflicts with other PRs.

@morningman morningman merged commit e701c05 into apache:master May 26, 2022
@morningman morningman added the dev/backlog waiting to be merged in future dev branch label May 26, 2022
@morrySnow morrySnow deleted the checkstyle_step3 branch May 26, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/backlog waiting to be merged in future dev branch kind/refactor Issues or PRs to refactor code reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] [FE Code Style] step3: turn on more whitespace, pad and wrap check

2 participants

@morrySnow @morningman