[Bugfix(Vec)] Fix some memory leak issues #9824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
Author
|
Fix another case: |
Contributor
|
hi @amosbird , please rebase master to fix BE ut bug. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
morningman
added
dev/merged-1.0.1-deprecated
morningman
pushed a commit
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Summary:
Fix some memory leak issues in vectorized engine.
Checklist(Required)
Further comments
The following leak issues are catched by running stress tests with tpch queries.
HashJoinNodedoesn't close owned expression contexts.VExprContextdoesn't free owned function contexts.AggregationNodedoesn't close owned aggregate_evaluators. Also it might fail to close properly.VExchangeNodedoesn't close owned vsort_exec_exprs.VSortNodedoesn't return error code if close fails.There is also a related fix proposed in #9820 whose implementation differs from
ExprContext. I think deallocation suits better inside d'tor, which is more consistent.