Skip to content

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented May 30, 2022

Proposed changes

Enable query vectorization and storage vectorization and storage low cardinality opt by default.

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yiguolei yiguolei added the dev/1.0.1-deprecated should be merged into dev-1.0.1 branch label May 30, 2022
dataroaring
dataroaring previously approved these changes May 30, 2022
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring added this to the v1.1 milestone May 30, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 30, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 30, 2022
@yiguolei yiguolei force-pushed the modify_default_vectorization branch from 9068b3e to 0cc5484 Compare May 31, 2022 11:15
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 31, 2022
@yiguolei yiguolei force-pushed the modify_default_vectorization branch 2 times, most recently from 6061ef0 to a565360 Compare June 2, 2022 07:04
hf200012
hf200012 previously approved these changes Jun 5, 2022
Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei force-pushed the modify_default_vectorization branch from a565360 to 4615277 Compare June 7, 2022 01:15
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 7, 2022
@yiguolei yiguolei force-pushed the modify_default_vectorization branch from 4615277 to da5e42f Compare June 8, 2022 01:14
@yiguolei yiguolei merged commit d9bbf67 into apache:master Jun 8, 2022
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Jun 9, 2022
morningman pushed a commit that referenced this pull request Jun 9, 2022
…tion and storage low cardinality optimization by default (#9848)

Co-authored-by: yiguolei <yiguolei@gmail.com>
@yiguolei yiguolei deleted the modify_default_vectorization branch March 30, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants