DRILL-8122: Change kafka metadata obtaining due to KAFKA-5697#2456
Merged
jnturton merged 1 commit intoapache:masterfrom Feb 16, 2022
Merged
DRILL-8122: Change kafka metadata obtaining due to KAFKA-5697#2456jnturton merged 1 commit intoapache:masterfrom
jnturton merged 1 commit intoapache:masterfrom
Conversation
luocooong
requested changes
Feb 10, 2022
cgivre
pushed a commit
to cgivre/drill
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRILL-8122: Change kafka metadata obtaining due to KAFKA-5697
Description
Consumer#poll(long)is deprecated starting from kafka 2.0. In Drill,Consumer#pollis used in 2 places:Kafka hasn't implemented a separate method to update metadata. And new implementation Consumer#poll(Duration) doesn't work with a hack that Drill use:
poll(0), due to changed logic: apache/kafka#4855 . That is why I had to use a loop with a timeout to workaround the absent separate method.Documentation
-
Testing
Unit tests