DRILL-8321: Change kafka_2.13 dependency scope to test #2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
bug
minor-update
dependencies
backport-to-stable
kingswanwho
pushed a commit
to kingswanwho/drill
that referenced
this pull request
Dec 9, 2022
kingswanwho
pushed a commit
to kingswanwho/drill
that referenced
this pull request
Dec 18, 2022
(cherry picked from commit 88f3c68)
jnturton
pushed a commit
that referenced
this pull request
Dec 19, 2022
(cherry picked from commit 88f3c68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8321: Change kafka_2.13 dependency scope to test
Description
Move
org.apache.kafka.kafka_2.13to test dependency scope. It prevents conflict between Scala versions oforg.apache.kafka.kafka_2.13(Scala 2.13) andcom.madhukaraphatak.java-sizeof_2.11(Scala 2.11). Solves such exceptions that could appear during Drill-On-Yarn startup:Also, it cleans Drill's classpath from unnecessary dependencies.
Probably
org.apache.kafka.kafka_2.13was added to compile scope by mistake.Documentation
No changes.
Testing
Unit tests pass successfully. Tried to connect to Kafka and read a topic - everything works fine.