DRILL-8324: Sizeof Refactor #2665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@cgivre My PR uses the latest Spark code for the SizeEstimator as opposed to very old copy of the Spark code that was copied and not maintained in java-sizeof lib. The new code gives slightly higher estimates for object instance sizes. Would this be an issue? Also, with tests - Spark and the java-sizeof lib use some Scala based tests - and they are not that easily replicated in Java. The question is whether the tests that I've added in this PR or if I need more. |
cgivre
added
code-cleanup
dependencies
backport-to-stable
cgivre
approved these changes
Oct 16, 2022
Contributor
cgivre
left a comment
cgivre
left a comment
There was a problem hiding this comment.
LGTM +1
@pjfanning Thanks for this.
Contributor
|
Given that this only affects the OpenTSDB plugin, I think it is fine. I've honestly never even heard of anyone actually using that with Drill. |
kingswanwho
pushed a commit
to kingswanwho/drill
that referenced
this pull request
Dec 9, 2022
kingswanwho
pushed a commit
to kingswanwho/drill
that referenced
this pull request
Dec 18, 2022
jnturton
pushed a commit
that referenced
this pull request
Dec 19, 2022
ashevchuk123
pushed a commit
to mapr/incubator-drill
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove use of java-sizeof jar. It is an old copy of Spark code. I have ported the latest Spark code to Java and inlined it.
Documentation
(Please describe user-visible changes similar to what should appear in the Drill documentation.)
Testing
(Please describe how this PR has been tested.)