Proposed publishing process for Docusaurus 2#392
Proposed publishing process for Docusaurus 2#392317brian wants to merge 98 commits intoapache:masterfrom
Conversation
|
@vogievetsky can you take a look at this and provide feedback on whether or not it works for you since you're the main site publisher. |
(cherry picked from commit b5a033f)
| @@ -0,0 +1,113 @@ | |||
| #!/usr/bin/python | |||
There was a problem hiding this comment.
One thing that stands out to me is the Python scripts here. Since we're already in Node world with Docusaurus and all, it would feel natural to me to have node scripts instead. That would likely also integrate much nicer with the package scripts.
There was a problem hiding this comment.
Thanks for taking a look, Andy! They're Python scripts mostly cause that's what @vtlim and I are most comfortable with. We don't have a strong attachment to them if anyone wants to redo them in a different language.
There was a problem hiding this comment.
Cool! I thought that might be the case, which makes sense; maybe @jgoz or myself will find some time. If not, we could always update this later on.
|
One issue I've found with this process is the "Edit this page" button on the doc pages. Because this is built in the intermediate repo using the
It doesn't look like there is an easy way to change it to not include latest, since this is the config: So I guess the question is which trade off do we want to make:
|
|
@317brian @vogievetsky , I'd like to suggest that we remove the "Edit button" at this point.
|
|
Closing this PR and manually porting the relevant changes to #394 |
(This PR would be merged after the Docusaurus2 upgrade in apache/druid and apache/druid-website-src)
This PR is meant purely to get feedback on the publishing process and the files listed under
relevant filesare the only ones that matter for that purpose. The conflicts will be resolved in the upgrade PR that will be opened.The Druid branch that this can be tested against is this one in my fork: 317brian/druid@26-docusaurus-test-branch
It is the 26 release with 4 additional commits:
The relevant files are:
READMEthat describes the publishing stepsbuild_docs.pythat builds the sitecopy_druid_docs.pythat copies the Druiddo_all_things.pythat's a wrapper forbuild_docsandcopy_druid_docsTo test this, clone my Druid fork and checkout the branch as a peer of this repo and use the instructions in the README
There are more files changed than those listed under relevant files because this also upgrades to docusaurus2 so that it can be tested (which is why the upgrade PR that will be opened needs to be merged first)
Thanks @vtlim, @ektravel , @demo-kratia, and @techdocsmith for helping get this together and testing it.
(This PR will be closed eventually and the relevant files listed above moved into the main PR for docusaurus2 to keep things neat)