Review resource handling in Sequence/Yielder subsystem

[leventov]

Examples of probable issues:

• https://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/ResourceClosingYielder.java#L56-L59 should probably look like (after closeable is ensured to be non-null, on construction)

  try (Closeable toClose = closeable) {
   baseYielder.close();
  }

  in order to

  • Benefit from exception suppression
  • Be consistent with ResourceClosingSequence.accumulate(), which closes the closeable after any resources of the wrapped sequence are closed (Currently in ResourceClosingYielder, we close closeable before baseYielder

• https://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/ResourceClosingSequence.java#L51-L57 should probably look like

  try {
    baseYielder = baseSequence.toYielder(initValue, accumulator);
  }
  catch (Throwable throwable) {
    try {
      closeable.close();
    }
    catch (Throwable t2) {
      throwable.addSuppressed(t2);
    }
    throw throwable;
  }

  Similarly here: https://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/BaseSequence.java#L85-L93 and here: https://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/BaseSequence.java#L138-L147

This task is blocked until java-util is merged into Druid.

/cc @cheddar