You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Be consistent with ResourceClosingSequence.accumulate(), which closes the closeableafter any resources of the wrapped sequence are closed (Currently in ResourceClosingYielder, we close closeablebeforebaseYielder
Examples of probable issues:
https://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/ResourceClosingYielder.java#L56-L59 should probably look like (after closeable is ensured to be non-null, on construction)
in order to
ResourceClosingSequence.accumulate(), which closes thecloseableafter any resources of the wrapped sequence are closed (Currently in ResourceClosingYielder, we closecloseablebeforebaseYielderhttps://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/ResourceClosingSequence.java#L51-L57 should probably look like
Similarly here: https://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/BaseSequence.java#L85-L93 and here: https://github.com/metamx/java-util/blob/fe9eefb0f143a191467976c0b1ff50ee47d5c6e0/src/main/java/com/metamx/common/guava/BaseSequence.java#L138-L147
This task is blocked until java-util is merged into Druid.
/cc @cheddar