FileSmoosher changes snuck in with java-util merge

[cheddar]

We moved java-util over to the druid repository to make it easier to iterate on functionality in there. This was spawned by a conversation from PR: metamx/java-util#55

Along with that move, we accidentally included the changes in FileSmoosher from that PR. This is an issue to make sure people are aware of what happened and to discuss what should be done to rectify the situation.

@akashdw

[gianm]

IMO since it already had one 👍 then a good solution is for someone else to take a look at the code before 0.9.3.

@cheddar could you confirm that the code moved in to druid in #3585 is equivalent to the diff currently in metamx/java-util#55? If so then that's probably the easiest place to review it.

[akashdw]

@cheddar @gianm Yes, code moved in to druid in #3585 is equivalent to the diff currently in metamx/java-util#55 except imports, package name and license.

[akashdw]

@gianm @cheddar Sorry for accidentally adding filesmoosher changes along with migration. I can open a pr to revert filesmoosher changes to make things more aligned with druid-io review process. What do you think?

[drcrallen]

I would rather label this a blocker for 0.9.3 and assume the review will be OK or minimal.

[gianm]

+1 to @drcrallen's suggestion.

[akashdw]

@cheddar @gianm @drcrallen Created a PR #3673 to address metamx/java-util#55 review comments.

[fjy]

Fixed by #3673