Skip to content

Refactor ClientQuerySegmentWalker to fix fluent workflow violation #5517

@a2l007

Description

@a2l007

Related to #5028
makeRunner inside ClientQuerySegmentWalker is designed to follow a fluent workflow but currently the usage of ResultLevelCachingQueryRunner does not completely adhere to this workflow.
Refactoring it to a fluent workflow is currently hindered by the nature of dependency between druid-processing and druid-server . FluentQueryRunnerBuilder which resides in druid-processing, cannot access ResultLevelCachingQueryRunner and most of the caching logic as they reside in druid-server.
Moving the ResultLevelCachingQueryRunner along with the caching logic into druid-processing is one approach towards making ClientQuerySegmentWalker#makeRunner cleaner but it may involve moving other related dependencies as well. Moving the FluentQueryRunner flow into druid-server is another approach which could be looked into.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions