Skip to content

Extract Combining Factories for Float/Double/Long First/Last aggregators #6039

@nishantmonu51

Description

@nishantmonu51

The parameter of NullableAggregatorFactory is not the output selector type, it's the input selector type. So it should be BaseFloatColumnValueSelector for FloatFirstAggregatorFactory. The reason why this refactoring couldn't be done right now is that getCombiningFactory() returns an anonymous subclass of FloatFirstAggregatorFactory, that IMO wrong. It seems to me that it should be a separate class FloatFirstCombiningAggregatorFactory extends NullableAggregatorFactory<ColumnValueSelector<SerializablePair<Long, Float>>>

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions