Skip to content

Remove CardinalityAggregatorColumnSelectorStrategy and CardinalityAggregatorColumnSelectorStrategyFactory as too shallow abstractions. #6909

@leventov

Description

@leventov

The logic of CardinalityAggregatorColumnSelectorStrategyFactory could be inlined in CardinalityAggregatorFactory.factorize() and factorizeBuffered() methods, and the logic of CardinalityAggregatorColumnSelectorStrategy could be expressed in subclasses of CardinalityBufferAggregator and CardinalityAggregator.

This change is similar to what is proposed here: #6397 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions