Skip to content

log but do not fail if memcached operations do not get queued in time#102

Merged
cheddar merged 3 commits intomasterfrom
cache-fixes
Mar 7, 2013
Merged

log but do not fail if memcached operations do not get queued in time#102
cheddar merged 3 commits intomasterfrom
cache-fixes

Conversation

@xvrl
Copy link
Copy Markdown
Member

@xvrl xvrl commented Mar 7, 2013

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This technically means that at the limit, we could experience timeout * 2 delay, correct? I.e. it could wait on the OpQueue right until timeout, when it gets taken out and runs, only to wait until timeout on the actual operation. This is not necessarily a problem, just want to understand if these are additive or if the thing is intelligent about taking into account both waits.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, this would mean it could take up to 1 second for an operation to complete, given that it will wait up to 500ms to get the operation in the queue and then up to 500ms for it to complete. Before it would wait up to 10s to get a slot in the queue.

From reading the spymemcached source code, it appears opTimeout is only used when doing synchronous gets / sets. In our case we set that timeout explicitely on the asyncGet call. I'm just setting it globally here in case it happens to affect anything else I am not aware of.

cheddar added a commit that referenced this pull request Mar 7, 2013
log but do not fail if memcached operations do not get queued in time
@cheddar cheddar merged commit a327954 into master Mar 7, 2013
@cheddar cheddar deleted the cache-fixes branch March 7, 2013 21:36
abhishekagarwal87 referenced this pull request in abhishekagarwal87/druid Dec 14, 2020
* Implement schema APIs

* Inspection fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants