Skip to content

Add WebIdentityTokenCredentialsProvider#10257

Closed
hyunjong-lee wants to merge 7 commits intoapache:masterfrom
hyunjong-lee:master
Closed

Add WebIdentityTokenCredentialsProvider#10257
hyunjong-lee wants to merge 7 commits intoapache:masterfrom
hyunjong-lee:master

Conversation

@hyunjong-lee
Copy link
Copy Markdown

@hyunjong-lee hyunjong-lee commented Aug 8, 2020

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Key changed/added classes in this PR
  • AWSCredentialsUtils
  • AWSModule

@hyunjong-lee hyunjong-lee changed the title [WIP] Add WebIdentityTokenCredentialsProvider Add WebIdentityTokenCredentialsProvider Aug 9, 2020
@hyunjong-lee
Copy link
Copy Markdown
Author

  • AWS module can't be tested by travis and also for code coverage.
  • I will test changed part in EKS cluster and share WEB_IDENTITY_TOKEN_FILE based auth result.

@hyunjong-lee
Copy link
Copy Markdown
Author

hyunjong-lee commented Aug 10, 2020

I had trying to use WEB_IDENTITY_TOKEN_FILE in S3.
While reading the code S3InputSource, I finally understand that access key using assume role will be timed-out after some period (default 1hour).
I did not intend this situation, so I finally understand why we should use AWS KEY directly without assume role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant