Skip to content

Remove legacy code from LogUsedSegments duty #10287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jihoonson merged 10 commits into from
Jan 12, 2021
Merged

Remove legacy code from LogUsedSegments duty #10287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2389128
allow the LogUsedSegments duty to be skippped
Aug 14, 2020
4b9a54b
Fixes for TravisCI coverage checks and documentation spell checking
Aug 15, 2020
e16219b
prameterize DruidCoordinatorTest in order to achieve coverage
Aug 16, 2020
71e7aba
Merge remote-tracking branch 'upstream/master' into logUsedSegmentsDu…
Oct 28, 2020
d6cf0ec
update config name to remove duty ref and improve documentation
Oct 29, 2020
60f2067
refine documentation for new config with reviewer advice
Oct 29, 2020
20bd6e2
add default column to docs for new config
Jan 5, 2021
1bf750d
Merge branch 'master' into logUsedSegmentsDuty-toggle
Jan 6, 2021
e77b320
remove legacy code in LogUsedSegments and remove config to disbale duty
Jan 8, 2021
c6d3ddf
fix makeHistoricalMangementDuties now that the returned list is alway…
Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ public int getCachedBalancerThreadNumber()
{
return cachedBalancerThreadNumber;
}

@VisibleForTesting
public ListeningExecutorService getBalancerExec()
{
Expand Down
12 changes: 2 additions & 10 deletions server/src/main/java/org/apache/druid/server/coordinator/duty/LogUsedSegments.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,9 @@ public DruidCoordinatorRuntimeParams run(DruidCoordinatorRuntimeParams params)
{
log.debug("Starting coordination. Getting used segments.");

DataSourcesSnapshot dataSourcesSnapshot = params.getDataSourcesSnapshot();
for (DataSegment segment : dataSourcesSnapshot.iterateAllUsedSegmentsInSnapshot()) {
if (segment.getSize() < 0) {
log.makeAlert("No size on a segment")
.addData("segment", segment)
.emit();
}
}

// Log info about all used segments
// Log info about all used segments only if debug logging is enabled
if (log.isDebugEnabled()) {
DataSourcesSnapshot dataSourcesSnapshot = params.getDataSourcesSnapshot();
log.debug("Used Segments");
for (DataSegment dataSegment : dataSourcesSnapshot.iterateAllUsedSegmentsInSnapshot()) {
log.debug(" %s", dataSegment);
Expand Down