Skip to content

Remove max rows per segment from compaction dialog#10404

Closed
ccaominh wants to merge 2 commits intoapache:masterfrom
ccaominh:compaction-dialog-no-max-rows-per-segment
Closed

Remove max rows per segment from compaction dialog#10404
ccaominh wants to merge 2 commits intoapache:masterfrom
ccaominh:compaction-dialog-no-max-rows-per-segment

Conversation

@ccaominh
Copy link
Copy Markdown
Contributor

Description

Configuring auto compaction with single_dim partitioning in the web console, requires specifying maxRowsPerSegment in the "Tuning config" field, rather than the "Max rows per segment" field. Specifying maxRowsPerSegment in the "Tuning config" also works for dynamic and hash partitions. To make the workflow consistent for all partitioning schemes, remove the "Max rows per segment" field so that the value is always specified in the "Tuning config" field.

Before

before

After

after


This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.

Configuring autocompaction with single_dim partitioning in the web
console, requires specifying maxRowsPerSegment in the "Tuning config"
field, rather than the "Max rows per segment" field. Specifying
maxRowsPerSegment in the "Tuning config" also works for dynamic and hash
partitions. To make the workflow consistent for all partitioning
schemes, remove the "Max rows per segment" field so that the value is
always specified in the "Tuning config" field.
@ccaominh
Copy link
Copy Markdown
Contributor Author

ccaominh commented Sep 22, 2020

Abandoning in favor of the improved compaction dialog UI added by #10417. I'll add the E2E tests in a different PR: #10425

@ccaominh ccaominh closed this Sep 22, 2020
@ccaominh ccaominh deleted the compaction-dialog-no-max-rows-per-segment branch October 4, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant