Skip to content

Applying modification pattern in #10025 to DataSegmentPusher#getDefaultStorageDirWithExistingUniquePath#10414

Closed
T45K wants to merge 1 commit intoapache:masterfrom
T45K:related_to_10025
Closed

Applying modification pattern in #10025 to DataSegmentPusher#getDefaultStorageDirWithExistingUniquePath#10414
T45K wants to merge 1 commit intoapache:masterfrom
T45K:related_to_10025

Conversation

@T45K
Copy link
Copy Markdown

@T45K T45K commented Sep 22, 2020

Description

In #10025, DataSegmentPusher#getDefaultStorageDir was modified, but its similar method, getDefaultStorageDirWithExistingUniquePath was not modified.
Wouldn't a similar modification be necessary?


This PR has:

  • been self-reviewed.
    • [] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Key changed/added classes in this PR
  • DataSegmentPusher

@stale
Copy link
Copy Markdown

stale Bot commented Dec 25, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Dec 25, 2020
@jihoonson
Copy link
Copy Markdown
Contributor

Hi @T45K, DataSegmentPusher.getDefaultStorageDirWithExistingUniquePath() is used only by ExportMetadata which is a tool to export data from metadata store. Since all segments in the metadata store must not be BucketNumberedShardSpec (it's checked in getDefaultStorageDir() and other places 🙂), this change doesn't seem necessary to me. I'm closing this PR, but please feel free to reopen if you think it's still useful.

@jihoonson jihoonson closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants