Move common configurations to TuningConfig#10478
Merged
clintropolis merged 1 commit intoapache:masterfrom Dec 4, 2020
Merged
Conversation
970a22e to
0cde1e0
Compare
0cde1e0 to
d04ed78
Compare
Eshcar
approved these changes
Oct 7, 2020
Eshcar
left a comment
There was a problem hiding this comment.
LGTM
All changes seem to improve code quality
can you just add a sentence (in the jira) explaining this is a preamble to a later PR that will add the I2 extension point
cf89ed6 to
72516c8
Compare
* Move common methods that are used in HadoopTuningConfig and in AppenderatorConfig to TuningConfig * Rename rowFlushBoundary in HadoopTuningConfig to maxRowsInMemory to match TuningConfig API
72516c8 to
ac36621
Compare
clintropolis
approved these changes
Dec 4, 2020
Member
|
I don't seem to be able to retry the failing CI which looks like it was a flaky test. |
Contributor
Author
|
Thanks, @clintropolis. |
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jan 22, 2021
* Move common methods that are used in HadoopTuningConfig and in AppenderatorConfig to TuningConfig * Rename rowFlushBoundary in HadoopTuningConfig to maxRowsInMemory to match TuningConfig API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to reduce code duplications and redundant code.
It does not affect Druid's UX. Only the internal code structure.
HadoopTuningConfigand inAppenderatorConfigtoTuningConfigrowFlushBoundaryinHadoopTuningConfigtomaxRowsInMemoryto matchTuningConfigAPI@JsonProperty("maxRowsInMemory"), but the method name did not matchTuningConfigAPIThis PR has:
Key changed/added classes in this PR
TuningConfigAppenderatorConfigHadoopTuningConfig