cleaning up and fixing links#10528
Merged
suneet-s merged 6 commits intoapache:masterfrom Dec 17, 2020
Merged
Conversation
added 2 commits
November 2, 2020 14:32
suneet-s
approved these changes
Dec 17, 2020
Contributor
suneet-s
left a comment
suneet-s
left a comment
There was a problem hiding this comment.
LGTM
Is there a script you ran to find all these broken links? We could add this to the travis job that runs on every PR to make sure we don't break them in the future
Author
|
Thanks @suneet-s. I didn't use a script, no. I found these by search & replace, since each one required manual confirmation. I think it may be possible to automate, if we could come up with a clever enough regex, but I didn't get there while making these changes. Maybe be worth looking into. |
Contributor
|
Thanks for the contribution @sthetland ! |
9 tasks
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jan 22, 2021
* cleaning up and fixing links * reverting local link * Update indexer.md * link checking * Fixing one more stale link for PostgreSQL
| ingestion tasks. These intermediate partial segments will not necessarily be identical across task replicas, so | ||
| remote cache types such as `memcached` will be ignored by task executor processes. | ||
|
|
||
| ## Unsupported queries |
Contributor
There was a problem hiding this comment.
Hi @sthetland what was the reason for removing this para in this PR? was it accidental?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the format of the links consistent to the prevailing style in the docs and fixes a few broken external links.
Using .md in link text rather than .html causes Docusarus to convert the links into absolute links rather than using relative links, making the docs easier to port to other contexts.
Also updating a few broken external links.