AWS Web Identity / IRSA Support#10541
Merged
pjain1 merged 5 commits intoapache:masterfrom Jan 25, 2021
himadrisingh:aws-web-identity-support
Merged
AWS Web Identity / IRSA Support#10541pjain1 merged 5 commits intoapache:masterfrom himadrisingh:aws-web-identity-support
pjain1 merged 5 commits intoapache:masterfrom
himadrisingh:aws-web-identity-support
Conversation
nishantmonu51
approved these changes
Oct 30, 2020
Member
nishantmonu51
left a comment
nishantmonu51
left a comment
There was a problem hiding this comment.
👍 ,
Please also make a small change to the doc here https://druid.apache.org/docs/latest/development/extensions-core/kinesis-ingestion.html#aws-authentication and mention WebIdentity token as well.
Contributor
|
+1 after the build |
clintropolis
approved these changes
Dec 2, 2020
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
travis is complaining about test coverage, but not sure what a meaningful test on AWSCredentialsUtils looks like heh
Contributor
|
hmmmm, yeah maybe just exclude it from coverage , @himadrisingh you can exclude that at https://github.com/apache/druid/blob/master/pom.xml#L1280 |
8 tasks
Contributor
|
@himadrisingh do you happen to know why |
didip
added a commit
to didip/druid
that referenced
this pull request
Mar 17, 2022
Original PR: apache#10541 doesn’t work. This PR addresses 2 of its issues: 1. Missing aws-java-sdk-sts.jar 2. applyAssumeRole function interferes with default s3Builder client behavior.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the latest AWS Web Identity Token Support for Druid.
Required fro IAM Roles for Service Account on kubernetes.
Updated AWS Credential Provider in the same order which AWS SDK does.
This PR has: