Introduce query/timeout/count metric#10567
Merged
himanshug merged 3 commits intoapache:masterfrom Nov 20, 2020
Merged
Conversation
Contributor
|
This looks good at initial glance. I'll test and submit a review tomorrow when I have some spare time |
capistrant
approved these changes
Nov 12, 2020
Contributor
capistrant
left a comment
There was a problem hiding this comment.
LGTM.
reviewed as well as pulled down code and ran locally. example metric:
{"feed":"metrics","timestamp":"2020-11-12T18:53:55.392Z","service":"druid/broker","host":"broker:8082","version":"0.21.0-SNAPSHOT","metric":"query/timeout/count","value":12}
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jan 22, 2021
* Add timeout metric * Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #10464.
This PR adds a new query metric
query/timeout/countthat represents the number of timed out queries during the emission period. Timed out query counts were previously clubbed underquery/interrupted/count. Having a separate metric for timed out queries can make it a little easier for cluster operators to diagnose query issues better.Marking this as
Incompatibleasquery/interrupted/countno longer represents timed out query counts and user defined alerting/reports may need to be adjusted to factor inquery/timeout/countalong withquery/interrupted/count.It would be useful to add metricsMonitors to integration tests so that it provides better testing for PRs such as this.
This PR has: