Skip to content

Fix doc about search query#10616

Merged
jihoonson merged 1 commit intoapache:masterfrom
FrankChen021:search_query_doc
Dec 2, 2020
Merged

Fix doc about search query#10616
jihoonson merged 1 commit intoapache:masterfrom
FrankChen021:search_query_doc

Conversation

@FrankChen021
Copy link
Copy Markdown
Member

Fixes #10610

Description

granularity property for a search query is not required based on the code which was introduced by #5157 .

This problem only exists for search query while the doc for other queries such as time-series query or group-by query is OK.

This PR fixes the doc to keep it in coincidence with the code.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jihoonson jihoonson merged commit 24f1e35 into apache:master Dec 2, 2020
@FrankChen021 FrankChen021 deleted the search_query_doc branch December 3, 2020 02:37
@jihoonson jihoonson added this to the 0.21.0 milestone Jan 4, 2021
JulianJaffePinterest pushed a commit to JulianJaffePinterest/druid that referenced this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search query - granularity - required? optional?

5 participants