document DynamicConfigProvider for kafka consumer properties#10658
Merged
himanshug merged 4 commits intoapache:masterfrom Dec 10, 2020
Merged
document DynamicConfigProvider for kafka consumer properties#10658himanshug merged 4 commits intoapache:masterfrom
himanshug merged 4 commits intoapache:masterfrom
Conversation
jihoonson
reviewed
Dec 8, 2020
Co-authored-by: Jihoon Son <jihoonson@apache.org>
Contributor
Author
|
thanks @jihoonson for quick review, applied both changes. |
jihoonson
approved these changes
Dec 8, 2020
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
@himanshug thanks for quick fix. +1 after CI.
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jan 22, 2021
…10658) * document DynamicConfigProvider for kafka consumer properties * Update docs/development/extensions-core/kafka-ingestion.md Co-authored-by: Jihoon Son <jihoonson@apache.org> * Update docs/development/extensions-core/kafka-ingestion.md * fix doc build Co-authored-by: Jihoon Son <jihoonson@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
documentation for #10309