fix integration test override config#10694
Merged
clintropolis merged 1 commit intoapache:masterfrom Dec 19, 2020
Merged
Conversation
…bles before calling compose
maytasm
approved these changes
Dec 18, 2020
suneet-s
approved these changes
Dec 19, 2020
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jan 22, 2021
…bles before calling compose (apache#10694)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of docker-scripts in #10680 broke the 'override' config integration test cluster bring up due to missing environment variables. This PR changes
docker_run_cluster.shto check forDRUID_INTEGRATION_TEST_OVERRIDE_CONFIG_PATHand it will call compose in the previous manner if set.stop_cluster.shwas also missing stopping the hadoop container, and likedocker_run_cluster.shwill also now check for and supply the env variables for override as well when stopping the integration test cluster when the overrides are defined.