Skip to content

Fix collision between #10689 and #10593.#10738

Merged
gianm merged 1 commit intoapache:masterfrom
gianm:fix-bad-merge
Jan 8, 2021
Merged

Fix collision between #10689 and #10593.#10738
gianm merged 1 commit intoapache:masterfrom
gianm:fix-bad-merge

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Jan 8, 2021

Master is busted right now due to in-flight collision between two recent patches.

Copy link
Copy Markdown
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after CI

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Jan 8, 2021

LGTM failed because it couldn't build master. I guess that check isn't going to be helpful. Let's see what Travis says.

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Jan 8, 2021

Travis passed. I'll merge this.

@gianm gianm merged commit 6eef0e4 into apache:master Jan 8, 2021
@gianm gianm deleted the fix-bad-merge branch January 8, 2021 17:52
JulianJaffePinterest pushed a commit to JulianJaffePinterest/druid that referenced this pull request Jan 22, 2021
@jihoonson jihoonson added this to the 0.21.0 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants