Web console: remove namespace prop that does not exist from JDBC lookup#10888
Merged
jihoonson merged 2 commits intoapache:masterfrom Feb 18, 2021
Merged
Web console: remove namespace prop that does not exist from JDBC lookup#10888jihoonson merged 2 commits intoapache:masterfrom
jihoonson merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
duplicate of #10886 ?? |
Contributor
|
I reverted the web console change in my PR in favor of this PR. |
9 tasks
capistrant
requested changes
Feb 16, 2021
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
LGTM once the jest snapshots get updated and pushed I think CI will pass and I will flip to approved.
capistrant
approved these changes
Feb 17, 2021
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
LGTM. The CI failure is the "Leadership availability Integration test" which I have noticed is very flaky
jihoonson
approved these changes
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there is no
namespaceproperty in JDBC lookups.druid/extensions-core/lookups-cached-global/src/main/java/org/apache/druid/query/lookup/namespace/JdbcExtractionNamespace.java
Line 41 in 753bce3
Removing it to make the UI more accurate.