Skip to content

Add instructions for updating licenses#10894

Merged
clintropolis merged 3 commits intoapache:masterfrom
jihoonson:license-doc
Mar 3, 2021
Merged

Add instructions for updating licenses#10894
clintropolis merged 3 commits intoapache:masterfrom
jihoonson:license-doc

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

Description

Managing licenses is hard.. This PR adds an instruction for how to update licenses.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jihoonson jihoonson added the Area - Dev For items related to the project itself, like dev docs and checklists, but not CI label Feb 17, 2021
@capistrant
Copy link
Copy Markdown
Contributor

This is awesome content and very informative! I don't know if I'm qualified to review since it is all new information to me. All of the content made sense to me, an uninformed dev, so that's good 👍

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for adding 👍

@clintropolis clintropolis merged commit d6e5912 into apache:master Mar 3, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Dev For items related to the project itself, like dev docs and checklists, but not CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants