Skip to content

Allow overlapping intervals for the compaction task#10912

Merged
maytasm merged 4 commits intoapache:masterfrom
jihoonson:allow-overlapping-interval
Mar 23, 2021
Merged

Allow overlapping intervals for the compaction task#10912
maytasm merged 4 commits intoapache:masterfrom
jihoonson:allow-overlapping-interval

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

Description

#10742 accidentally introduced a regression bug that the compaction task doesn't allow overlapping intervals. This is a valid use case where you run a compaction task that overwrites a segment of a huge interval and other segments of smaller intervals that overlap the huge one.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suneet-s
Copy link
Copy Markdown
Contributor

suneet-s commented Mar 5, 2021

Is this to fix #10911?

@jihoonson
Copy link
Copy Markdown
Contributor Author

No, this doesn't fix #10911.

@maytasm maytasm merged commit a041933 into apache:master Mar 23, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants