Skip to content

Add javadoc and test for Granularity configs in Compaction / Auto Compaction#10938

Merged
asdf2014 merged 1 commit intoapache:masterfrom
maytasm:IMPLY-5800-2
Mar 3, 2021
Merged

Add javadoc and test for Granularity configs in Compaction / Auto Compaction#10938
asdf2014 merged 1 commit intoapache:masterfrom
maytasm:IMPLY-5800-2

Conversation

@maytasm
Copy link
Copy Markdown
Contributor

@maytasm maytasm commented Mar 2, 2021

Add javadoc and test for Granularity configs in Compaction / Auto Compaction

Description

This is a followup to #10900

  • Add javadocs
  • Add tests
  • Rename variables

Note that there is no functionality change in this PR

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Copy Markdown
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast follow! LGTM

@suneet-s suneet-s added the Area - Dev For items related to the project itself, like dev docs and checklists, but not CI label Mar 3, 2021
Copy link
Copy Markdown
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asdf2014 asdf2014 merged commit 2333391 into apache:master Mar 3, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Dev For items related to the project itself, like dev docs and checklists, but not CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants