Skip to content

Show leader nodes in Services Tab#10951

Merged
vogievetsky merged 1 commit intoapache:masterfrom
FrankChen021:show_leader2
Mar 9, 2021
Merged

Show leader nodes in Services Tab#10951
vogievetsky merged 1 commit intoapache:masterfrom
FrankChen021:show_leader2

Conversation

@FrankChen021
Copy link
Copy Markdown
Member

This PR is a replacement for #10418 .

The core changes at the server side in #10418 has been implemented in #10680, and based on that implementation, a is_leader column is added to 'servers' table which means user could know which nodes are playing in a role of leader by querying 'servers' table.

This PR provides a more convenient, intuitive way for users to get leader information - by showing the information in 'Details' column under 'Services' tab.

image

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Signed-off-by: frank chen <frank.chen021@outlook.com>
@FrankChen021
Copy link
Copy Markdown
Member Author

Hi @vogievetsky , Could you help review this PR ?

Copy link
Copy Markdown
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Copy Markdown
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Very helpful

@vogievetsky vogievetsky merged commit 80ec285 into apache:master Mar 9, 2021
@FrankChen021 FrankChen021 deleted the show_leader2 branch March 11, 2021 02:13
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants