Show leader nodes in Services Tab#10951
Merged
vogievetsky merged 1 commit intoapache:masterfrom Mar 9, 2021
Merged
Conversation
Signed-off-by: frank chen <frank.chen021@outlook.com>
Member
Author
|
Hi @vogievetsky , Could you help review this PR ? |
vogievetsky
approved these changes
Mar 9, 2021
Contributor
vogievetsky
left a comment
There was a problem hiding this comment.
Looks great. Very helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for #10418 .
The core changes at the server side in #10418 has been implemented in #10680, and based on that implementation, a
is_leadercolumn is added to 'servers' table which means user could know which nodes are playing in a role of leader by querying 'servers' table.This PR provides a more convenient, intuitive way for users to get leader information - by showing the information in 'Details' column under 'Services' tab.
This PR has: