Fix regression introduced by #11008#11013
Merged
suneet-s merged 2 commits intoapache:masterfrom Mar 20, 2021
Merged
Conversation
suneet-s
reviewed
Mar 18, 2021
| if (authorizer instanceof AllowAllAuthorizer) { | ||
| return resources; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Could we add a test to prevent someone accidentally making this addition in the future. I read the previous patch and thought this was a good optimization too.
Contributor
Author
There was a problem hiding this comment.
Good call, @suneet-s . I added a unit test in the new commit and in the process I found that we can still skip authorizing the resources when AllowAllAuthorizer is configured.
…on when AllowAllAuthorizer is configured. Add a unit test to validate that the change doesn't introduce new behavior.
suneet-s
approved these changes
Mar 19, 2021
Contributor
suneet-s
left a comment
suneet-s
left a comment
There was a problem hiding this comment.
Nice! LGTM
Maybe we should wait for @abhishekagarwal87 to take a look too, since he spotted the regression in the previous patch.
abhishekagarwal87
approved these changes
Mar 19, 2021
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11012 .
This PR has: