Enforce allow list for JDBC properties by default#11063
Merged
jihoonson merged 2 commits intoapache:masterfrom Apr 7, 2021
Merged
Enforce allow list for JDBC properties by default#11063jihoonson merged 2 commits intoapache:masterfrom
jihoonson merged 2 commits intoapache:masterfrom
Conversation
clintropolis
approved these changes
Apr 5, 2021
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
I think this should be ok, as long as we call it out in the release notes (and mysql doesn't invent any new JDBC URI formats that the matcher misses since allowUnknownJdbcUrlFormat is set to true)
jihoonson
added a commit
to jihoonson/druid
that referenced
this pull request
Apr 13, 2021
* Enforce allow list for JDBC properties by default * fix tests
jihoonson
added a commit
that referenced
this pull request
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A follow-up to #11047. This PR changes the default to enforce the allow list for JDBC connection properties.
allowUnknownJdbcUrlFormatstill remains as true by default because, at least the known security vulnerability can be exploitable only with MySQL which Druid will always enforce the allow list once it's enabled regardless ofallowUnknownJdbcUrlFormat.This PR has: