Make dropExisting flag for Compaction configurable and add warning documentations#11070
Merged
maytasm merged 11 commits intoapache:masterfrom Apr 9, 2021
Merged
Make dropExisting flag for Compaction configurable and add warning documentations#11070maytasm merged 11 commits intoapache:masterfrom
maytasm merged 11 commits intoapache:masterfrom
Conversation
Contributor
|
LGTM |
Member
|
@jihoonson Sure, thanks. |
Contributor
Author
|
@asdf2014 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make dropExisting flag for Compaction configurable and add warning documentations
Description
In PR #11025 I have introduced a new option for ingestion task to drop (mark unused) all existing segments that are contained by the interval in the ingestionSpec. However, it was pointed out after the PR was merged that this new option can cause temporary data unavailability for data within the specified interval of the ingestion task. Compaction task created manually and by auto compaction were hardcoded to always use the new dropExisting flag in PR #11025. This PR make dropExisting flag for Compaction task configurable and set the default behavior when dropExisting is not specified to not use the dropExisting functionality (which is the same behavior as before the PR #11025). This PR also adds documentation with warning to temporary data unavailability if dropExisting flag is used.
This PR does not contain the fix for this problem yet. The fix will come later.
This PR has: