Issue #10953: ARM64 - Build and test on AWS Graviton2 node#11109
Issue #10953: ARM64 - Build and test on AWS Graviton2 node#11109martin-g wants to merge 5 commits intoapache:masterfrom martin-g:feature/arm64-on-graviton2-3
Conversation
There was a problem hiding this comment.
maybe it would be worth trying with a smaller segment size (ROWS_PER_SEGMENT) instead of skipping the test entirely?
There was a problem hiding this comment.
I am not 100% certain but I think there is a memory leak in an earlier test(s).
ExpressionVectorSelectorsTest does not fail on my Ubuntu 20.04 ARM64 VM. I have tried even with much lower max memory - it passes with -Xmx384m. The test suite at TravisCI runs with -Xmx3000m.
Locally with -Xmx256m it fails with OOME Too much garbage collections.
There was a problem hiding this comment.
Tried with twice smaller ROWS_PER_SEGMENT with 48ab08c. Let's see!
There was a problem hiding this comment.
@clintropolis With this change the unit test passed: https://travis-ci.com/github/apache/druid/builds/223430180
Some other non-related TravisCI jobs failed for reasons not related to this PR, but the new ARM64 ones passed successfully.
There was a problem hiding this comment.
👍, in that case please remove this commented section and the no longer used CPU_ARCH.
There was a problem hiding this comment.
Done!
Also rebased to latest master.
There was a problem hiding this comment.
should probably consider adding sql to this set too so we at least have coverage of most core Druid things.
There was a problem hiding this comment.
I've split the ARM64 job into two jobs with two different sets of modules to test.
This is needed because otherwise TravisCI will kill the job if it takes more than 50mins.
Documentation: - https://blog.travis-ci.com/2020-09-11-arm-on-aws - https://aws.amazon.com/blogs/opensource/getting-started-with-travis-ci-com-on-aws-graviton2/ Trying to fix the problem described at #10953
... because at the moment they took 1h which is a little bit above the TravisCI limit of 50mins per job and because @clintropolis requested to add one more module - sql
Suggested-by: clintropolis
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
Done with #12451 |
Documentation:
Fixes the problem described at #10953