Skip to content

Issue #10953: ARM64 - Build and test on AWS Graviton2 node#11109

Closed
martin-g wants to merge 5 commits intoapache:masterfrom
martin-g:feature/arm64-on-graviton2-3
Closed

Issue #10953: ARM64 - Build and test on AWS Graviton2 node#11109
martin-g wants to merge 5 commits intoapache:masterfrom
martin-g:feature/arm64-on-graviton2-3

Conversation

@martin-g
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@clintropolis clintropolis Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it would be worth trying with a smaller segment size (ROWS_PER_SEGMENT) instead of skipping the test entirely?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% certain but I think there is a memory leak in an earlier test(s).
ExpressionVectorSelectorsTest does not fail on my Ubuntu 20.04 ARM64 VM. I have tried even with much lower max memory - it passes with -Xmx384m. The test suite at TravisCI runs with -Xmx3000m.
Locally with -Xmx256m it fails with OOME Too much garbage collections.

Copy link
Copy Markdown
Member Author

@martin-g martin-g Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with twice smaller ROWS_PER_SEGMENT with 48ab08c. Let's see!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clintropolis With this change the unit test passed: https://travis-ci.com/github/apache/druid/builds/223430180

Some other non-related TravisCI jobs failed for reasons not related to this PR, but the new ARM64 ones passed successfully.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, in that case please remove this commented section and the no longer used CPU_ARCH.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!
Also rebased to latest master.

Comment thread .travis.yml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably consider adding sql to this set too so we at least have coverage of most core Druid things.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will add it!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've split the ARM64 job into two jobs with two different sets of modules to test.
This is needed because otherwise TravisCI will kill the job if it takes more than 50mins.

@stale
Copy link
Copy Markdown

stale Bot commented Apr 28, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Apr 28, 2022
@martin-g
Copy link
Copy Markdown
Member Author

martin-g commented May 3, 2022

Done with #12451

@martin-g martin-g closed this May 3, 2022
@martin-g martin-g deleted the feature/arm64-on-graviton2-3 branch May 3, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants