fix Dockerfile steps order#11148
Closed
NoamShaish wants to merge 1 commit intoapache:masterfrom
NoamShaish:master
Closed
fix Dockerfile steps order#11148NoamShaish wants to merge 1 commit intoapache:masterfrom NoamShaish:master
NoamShaish wants to merge 1 commit intoapache:masterfrom
NoamShaish:master
Conversation
Member
|
Hi @NoamShaish, your change seems to undo the docker image size optimization introduced in #10506 which introduced this bug. I believe #11167 should fix the problem while avoiding the increase in the image size. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
Member
|
Hello @NoamShaish Thank you for your contribution. There should be no such problem since 0.23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11137.
Description
This PR fix the Docker build sequence which is broken.
I moved the copy of the builder opt directory to be before the creation of /opt/druid/var since it collides with the copied content.
Key changed/added files in this PR
/distribution/docker/DockerfileThis PR has: