Revert "Adjust HadoopIndexTask temp segment renaming to avoid potential race conditions"#11151
Merged
jon-wei merged 1 commit intoapache:masterfrom Apr 22, 2021
Merged
Revert "Adjust HadoopIndexTask temp segment renaming to avoid potential race conditions"#11151jon-wei merged 1 commit intoapache:masterfrom
jon-wei merged 1 commit intoapache:masterfrom
Conversation
…al race conditions (apache#11075)" This reverts commit a2892d9.
jihoonson
approved these changes
Apr 22, 2021
zachjsh
added a commit
to zachjsh/druid
that referenced
this pull request
May 3, 2021
… potential race conditions (apache#11075)" (apache#11151)" This reverts commit 49a9c3f.
zachjsh
added a commit
that referenced
this pull request
May 5, 2021
* Do stuff * Do more stuff * * Do more stuff * * Do more stuff * * working * * cleanup * * more cleanup * * more cleanup * * add license header * * Add unit tests * * add java docs * * add more unit tests * * Cleanup test * * Move removing of workingPath to index task rather than in hadoop job. * * Address review comments * * remove unused import * * Address review comments * Do not overwrite segment descriptor for segment if it already exists. * * add comments to FileSystemHelper class * * fix local hadoop integration test * * Fix failing test failures when running with java11 * Revert "Revert "Adjust HadoopIndexTask temp segment renaming to avoid potential race conditions (#11075)" (#11151)" This reverts commit 49a9c3f. * * remove JobHelperPowerMockTest * * remove FileSystemHelper class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11075 since it is causing a jdk11 unit test failure in "indexing modules test"