InDimFilter: Fix cache key computation to avoid collisions.#11168
Merged
gianm merged 2 commits intoapache:masterfrom Apr 29, 2021
Merged
InDimFilter: Fix cache key computation to avoid collisions.#11168gianm merged 2 commits intoapache:masterfrom
gianm merged 2 commits intoapache:masterfrom
Conversation
The prior code did not include separation between values, and encoded null ambiguously. This patch fixes both of those issues by encoding strings as length + value instead of just value. I think cache key computation was OK prior to apache#9800. Prior to that patch, the cache key was computed using CacheKeyBuilder.appendStrings, which encodes strings as UTF-8 and inserts a separator byte (0xff) between them that cannot appear in a UTF-8 stream.
jihoonson
approved these changes
Apr 27, 2021
Contributor
|
Nice catch 👍 |
clintropolis
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior code did not include separation between values, and encoded
null ambiguously. This patch fixes both of those issues by encoding
strings as length + value instead of just value.
I think cache key computation was OK prior to #9800. Prior to that
patch, the cache key was computed using CacheKeyBuilder.appendStrings,
which encodes strings as UTF-8 and inserts a separator byte (0xff)
between them that cannot appear in a UTF-8 stream.